Vienna oDesk Feed Bug

An RSS/Atom newsreader with features comparable to commercial newsreaders.

Vienna oDesk Feed Bug

Postby dmitry.matora » Wed Dec 05, 2012 12:04 am

When trying to read oDesk jobs feed (like this one https://www.odesk.com/jobs/rss?q=rss ) using Vienna
"click to apply" button (within the article) does not open expected page.

The problem is that "click to apply" url uses html encoded tilda so the browser (or Vienna) tries to open url like
https://www.odesk.com/jobs/Data-scraping-script-site_%25257E01957b6deda6d44f1d?source=rss
and sometimes like %257E instead of %25%257E

while it should be opening url like
https://www.odesk.com/jobs/Data-scraping-script-site_~01957b6deda6d44f1d?source=rss
or at least %7E instead of %257E and %25%257E

Same feed works fine at feedreader (popular windows RSS client) but I'd really like to avoid using Parallels for a number of reasons :)
It would be really nice if you get this fixed :)

I am using Lion 10.7.5 and the issue can be reproduced on both 3.0b.2821 and 2.6.0.2601 Vienna,
both "open links in external browser" switched on or off
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Thu Dec 06, 2012 8:48 pm

Thanks for reporting this. A fix has been submitted, and will probably be included in the next beta.
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Thu Dec 06, 2012 9:02 pm

Sad thing is starting today, odes feeds refuse to refresh at all
giving me yellow triangles instead
Attachments
Screensnap 071212125636.png
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Thu Dec 06, 2012 9:03 pm

While feedreader works fine
Attachments
Screensnap 071212125751.png
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Thu Dec 06, 2012 10:01 pm

dmitry.matora wrote:Sad thing is starting today, odes feeds refuse to refresh at all
giving me yellow triangles instead


What is reported by the Activity Window ?
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Thu Dec 06, 2012 10:08 pm

Error parsing XML data in feed
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Thu Dec 06, 2012 11:24 pm

Nothing similar here for the feed you listed in your first message...
Try relaunching Vienna.

If the issue persist, use "Show XML source" for one of the problematic sources, and send me the content... barijaona at gmail com
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Thu Dec 06, 2012 11:44 pm

barijaona wrote:Nothing similar here for the feed you listed in your first message…

Well i just added https://www.odesk.com/jobs/rss?q=rss and experienced same issue

barijaona wrote:Try relaunching Vienna.

Didn't help

barijaona wrote:If the issue persist, use "Show XML source" for one of the problematic sources, and send me the content... barijaona at gmail com

I've sent you https://www.odesk.com/jobs/rss?q=rss content.
If that won't help i can provide you with teamviewer access to my laptop
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 2:15 am

It's taking ages.
I am a developer and willing to contribute to the project.
Is anyone willing to give me a hand on that?
I might need help with compiling the sources.
And it would be helpful to get y hands on the patch you have developed
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 2:51 am

I've got code from git (master branch) and compiled it using Xcode 4.5.2
I'm trying to check what version it is and it says Master :9d5567a:
How is it related to 3.0b and 2.6?
Last edited by dmitry.matora on Fri Dec 28, 2012 3:10 am, edited 1 time in total.
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 3:09 am

Interesting, when i click Show XML Source it gives me this code
Code: Select all
<html><head><script type='text/javascript'>window.location = 'https://www.odesk.com/login?redir=' +encodeURIComponent(window.location.pathname + window.location.hash);</script></head><body></body></html>

on 3.0b if i go to internal browser and authorize myself at odesk.com, rss update works.
on 2.6 it doesn't help
on 3.0b it get's broken everytime i restart Vienna

If i do simple wget on the url, it will give me rss, instead of asking for password.
it seems like Vienna is messing up with the url or cookies, or something.
Btw, how do i reset Vienna cookies?
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 3:14 am

Ok, clearing Safari cookies solves the issue even for 2.6 :)
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 4:50 am

But that's not a solution, since i need to authorize myself to work with the article.
I've went through the Vienna sources, and found preFlightValidation function at RichXMLParser.m that could be responsible for turning % into %25
It seems like master branch already has your patch included, since compiled version has no issue with clicking on "apply" link.

These is an issue with using cookies though.
It would be really nice to be able to disable cookies for rss request.

I've gone through RefreshManager.m where connection management seems to be happening, but my knowledge of this language and libraries (whatever they are) doesn't seem to be sufficient at this point. Any tips are really apretiated
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Fri Dec 28, 2012 6:27 am

Ok i got oDesk not refreshing issue fixed by replacing
Code: Select all
      [myRequest setUsername:[folder username]];
      [myRequest setPassword:[folder username]];

with
Code: Select all
      [myRequest setUsername:[folder username]];
      [myRequest setPassword:[folder username]];
      [myRequest setUseCookiePersistence:NO];

at RefreshManager.m (Line 472)

I don't expect this patch be included in mainstream version, since it's probably harmfull, but it would be nice to have an option for each feed, whenever cookies should be used or not.
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Mon Dec 31, 2012 4:54 pm

After reflecting on it, I think that your fix is accurate...

Persistent cookies are useful for the browser part of Vienna, much less for fetching RSS feeds. Anyway, cookies set by Webkit/Safari elsewhere should not supersede Vienna's username/passwords settings.
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Wed Jan 02, 2013 1:42 pm

So who is that single Vienna developer David Munch was talking about?
barijaona is it you?
Do you feel like giving me a hand on implementing smart folder counters functionality?
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Wed Jan 02, 2013 10:00 pm

As I said in this thread, I will help if you start something. This feature might be interesting, but I have yet to see if it is worth the cost.
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Wed Jan 02, 2013 11:46 pm

barijaona wrote:As I said in this thread, I will help if you start something. This feature might be interesting, but I have yet to see if it is worth the cost.

Well i need help rather in the beginning, than after it.
I need some explanation on the code.
How do you feel about talking things through on Skype screensharing session?
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Re: Vienna oDesk Feed Bug

Postby barijaona » Thu Jan 03, 2013 11:35 am

On which timezone are you ?
I am on TZ+3, and I only get a decent connectivity on evenings and early mornings.
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
barijaona
Vienna Team
 
Posts: 470
Joined: Sat Nov 12, 2011 6:10 am

Re: Vienna oDesk Feed Bug

Postby dmitry.matora » Thu Jan 03, 2013 8:40 pm

Right now i'm on GMT+11
I have quite a few friends on GMT+2/GMT+4 - if i wake up early enough or stay awake long enough, we can meet :)
What's your Skype?
dmitry.matora
Harmless
 
Posts: 17
Joined: Tue Dec 04, 2012 11:22 pm

Next

Return to Vienna

Who is online

Users browsing this forum: Google Feedfetcher