I think by adding a post with some invalid content (whatever that is, I think all content should be valid and be properly encoded or escaped), I somehow broke a trac ticket (bad thing,can be used to run a DoS or any other form of database/webpage attack).
Here, this ticket does not render correctly anymore, after I added a reply to it:
http://trac.adiumx.com/ticket/6565
Maybe someone can have a look at that.
I broke trac
Looks like this is CSRF protection at work. Ran it by the trac guys, they said it's alright. Do you have the text of your comment? If so I can delete it from the database and we could retry getting it posted in a text file attachment possibly.
-
coderanger
- Harmless
- Posts: 1
- Joined: Wed Mar 14, 2007 3:40 am
Yes, I will preview them in the future for sure.
On the other hand I still think it should not happen in the first place. There are evil people on the Internet (remember "Evil Internet(TM)"), they could sign up for an account and then break all active trac tickets. You'll ask, why should anyone do this? Well, why do people write viruses that delete your documents? Because they are evil.
Anyway, I got this bug fixed, attached a patch. My first Adium Bugfix ever
And it was a really silly bug. In my company they had charged me for that; if you write code and commit it and this code has a silly bug (silly meaning: someone else who has never seen the code before can tell you there is a bug with only a single review of the code), we have to pay 2 Euros into the office piggy bank
Not a bad thing, though. At the end of the year we take the money and go bowling.
On the other hand I still think it should not happen in the first place. There are evil people on the Internet (remember "Evil Internet(TM)"), they could sign up for an account and then break all active trac tickets. You'll ask, why should anyone do this? Well, why do people write viruses that delete your documents? Because they are evil.
Anyway, I got this bug fixed, attached a patch. My first Adium Bugfix ever
And it was a really silly bug. In my company they had charged me for that; if you write code and commit it and this code has a silly bug (silly meaning: someone else who has never seen the code before can tell you there is a bug with only a single review of the code), we have to pay 2 Euros into the office piggy bank
Not a bad thing, though. At the end of the year we take the money and go bowling.