Page 1 of 6

Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Fri Apr 11, 2008 2:08 pm
by visionkrew
I finally managed to merge a msnp14-enabled libpurple (source from the pidgin trunk) build to Adium 1.3svn. Of course the devs were right, it's really buggy.

For example: I can log in to the msn service...however, if I try to change my display name, my msn account disconnects immediately. The debug log says:

04:03:50: <ESPurpleMSNAccount:6c5aad0 1>:me@something.com: gotFilteredDisplayName: g- (I am currently g)
04:03:50: (Libpurple: msn) C: NS 000: REA 23 me@something.com g%2d
04:03:50: <ESPurpleMSNAccount:6c5aad0 1>:me@something.com: Updating status for key: FullNameAttr
>>>>>>>>>> 04:03:50: (Libpurple: msn) servconn read error,len: 0, errno: 2, error: No such file or directory <<<<<<<<<<
04:03:50: (Libpurple: msn) Connection error from Notification server (207.46.106.103): Reading error
04:03:50: (Libpurple: msn) C: NS 000: OUT
04:03:50: Connection Disconnected: gc=ba7b040 (Connection error from Notification server:
Reading error)
04:03:50: <ESPurpleMSNAccount:6c5aad0 1>:me@something.com accountConnectionReportDisconnect: Connection error from Notification server:
Reading error
04:03:50: (Libpurple: account) Disconnecting account 0x970dae0
04:03:50: (Libpurple: connection) Disconnecting connection 0xba7b040
04:03:50: (Libpurple: connection) Deactivating keepalive.
04:03:50: (Libpurple: msn) destroy httpconn (0xb7ef360)
04:03:50: (Libpurple: OIM) destroy the OIM
04:03:50: Disconnected: gc=ba7b040

Here, my original display name was "g"...I tried to change that to "g-" when the error occured.

What do you think? Is it a libpurple, or Adium bug?

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Fri Apr 11, 2008 8:34 pm
by markes

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sat Apr 12, 2008 9:02 pm
by evands
visionkrew wrote: For example: I can log in to the msn service...however, if I try to change my display name, my msn account disconnects immediately. The debug log says:
that, and probably only that, is an Adium bug. Change NEW_MSN be defined to TRUE in ESPurpleMSNAccount.h.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sun Apr 13, 2008 2:17 pm
by visionkrew
evands wrote:Change NEW_MSN be defined to TRUE in ESPurpleMSNAccount.h.
Thank you!!

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sun Apr 13, 2008 3:04 pm
by Binarymix
Visionkrew, could you post your custom build for those of us that aren't as code savy? :)

And what features does this include other than personal messages? Does MSNP14 allow you to send custom emotes, and show offline messages?

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sun Apr 13, 2008 3:27 pm
by zac
On a side note, MSN P14 in im.pidgin.pidgin has almost none of the fixes that the MSN P15 branch has, like being able to stay online for extended periods of time.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Tue Apr 15, 2008 1:32 pm
by spadario
I saw msnp14 changes into timeline...
Do I need to apply the patch or is it already applied into svn source?
Thanks in advance ;)

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Tue Apr 15, 2008 4:45 pm
by cheungpat
Ah, so much has changed, it is even easier to build Purple into Adium with msnp14 enabled.
I just tried and I am not as lucky: My freshly checked out and built Adium won't connect to msn and it get stuck at the 75% level.

@Binarymix
it's really buggy, it is not as if it is being hold back for stability issues. You see, I can't even make it to work. Of course it maybe my own problem :???: .

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Tue Apr 15, 2008 6:18 pm
by visionkrew
My build seems to work just fine. I've checked out the im.pidgin.pidgin.khc.msnp15 branch, then I applied most of the existing patches (which I found attached to the "Activate MSNPV14" related active tickets in the Pidgin Trac) to it. Finally I've successfully built that into Adium 1.3svn [r23119].

cheungpat: Check out your ticket at http://developer.pidgin.im/ticket/5212 ...you can use one of the attached patches to fix your connection problem.

Question for the Devs: is it okay to post a link to my build here?

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Tue Apr 15, 2008 9:10 pm
by evands
visionkrew wrote:My build seems to work just fine. I've checked out the im.pidgin.pidgin.khc.msnp15 branch, then I applied most of the existing patches (which I found attached to the "Activate MSNPV14" related active tickets in the Pidgin Trac) to it. Finally I've successfully built that into Adium 1.3svn [r23119].

cheungpat: Check out your ticket at http://developer.pidgin.im/ticket/5212 ...you can use one of the attached patches to fix your connection problem.

Question for the Devs: is it okay to post a link to my build here?
It's fine by me as long as the versioning information within Adium clearly indicates that it is an svn built with msnp14... I assume you're using the Makefile in the Release folder to build Adium, so just set your VERSION string to "1.3svn23119-msnp14-unsupported" or the like. That way version checking will still know that a 1.3 final supercedes it and users who obtain it secondhand will be notified that it is an unsupported build.

I hope you're able to help report and fix any remaining issues you find. None of the core Adium developers use MSN regularly, and it's very difficult to do bug testing with a protocol you don't use heavily.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Fri Apr 18, 2008 4:39 pm
by Dusan
I'd love to try this one as well

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sun Apr 20, 2008 1:06 am
by visionkrew
removed my post.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Sun Apr 20, 2008 8:05 am
by markes
most of the bugs under the milestone seem to have patches, so there's a progress :)

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 1:27 pm
by NiKo2005
I'd be interested in trying this build too ;)

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 1:45 pm
by Dimmuxx
I would really like to test msnp15 too. This build is pretty outdated now though so hopefully someone will make a newer one and upload it somewhere since visionkrew doesn't seem to post his.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 7:38 pm
by visionkrew
I'll post my build, I just want to make sure it's worth the upload. If everything goes well, you'll see it this night. :)

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 7:50 pm
by spiz
thanks loads visionkrew :) looking forward to it!

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 8:39 pm
by Dimmuxx
visionkrew wrote:I'll post my build, I just want to be sure that it's worth the upload. If everything goes well, you'll see it this night. :)
Oh, that's nice. :)

Btw, I would appreciate it if you could list all the patches that you included from the activate msnp14/15 milestone. Does changing avatar work since that doesn't seem to have a patch yet.

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 10:31 pm
by visionkrew
So here it goes:

Adium X 1.3svn with MSNP14 enabled:
[url]http://sl_skr.extra.hu/files/Adium_1.3svn-23184-msnp14_enabled-unsupported.dmg[/url]
http://rapidshare.com/files/109790693/A ... d.dmg.html


This UNOFFICIAL, probably unstable build of Adium X has MSNP14 (personal messages, etc.) enabled.


Build information:


libpurple:
----------

Built from the im.pidgin.pidgin.khc.msnp15 Pidgin branch.

Patches applied to fix the following issues:

- MSNP14 does not update tokens correctly,
- MSNP14 hangs on connection to login.live.com,
- MSNP14 SOAP does not check if a pre-existing connection is still open when attempting to send.

(Changing avatar worked for me.)


Adium X:
--------

Version: 1.3svn, revision 23184 (from the Adium trunk).

Build-configuration: Deployment-Debug (if you experience anything weird, please make use of the Debug Window and help report any remaining issues).

Re: Adium 1.3svn + libpurple with MSNP14 enabled

Posted: Mon Apr 21, 2008 10:53 pm
by NiKo2005
I'm testing it right now and it seems to work just fine, thanks :)