Auto-scrolling not working after upgrade to Catalina

An instant messenger which can connect to AIM, GTalk, Jabber, ICQ, and more.
User avatar
Robby
Cocoaforge Admin
Posts: 2610
Joined: Mon May 01, 2006 3:00 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by Robby »

doomsday wrote:hi guys. any good news someone? :)
I've merged Trolan's first pull request (https://bitbucket.org/adium/adium/pull- ... ublic-apis). I've been testing the scrolling fix from the second one (https://bitbucket.org/adium/adium/pull- ... o-use-more) and I'm almost ready to merge it, too. Then, I'll ask former, veteran Adium developers to help with releasing a new version.

I'm also preparing a plan for how to get proper development of Adium up and running again.

Does that sound good for now? =-)
spelunker
Harmless
Posts: 11
Joined: Tue Oct 08, 2019 8:11 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by spelunker »

Sounds absolutely excellent. Fingers crossed for a good outcome. A cautious well done to everyone who’s worked on this
bootOnWing
Harmless
Posts: 2
Joined: Thu Oct 24, 2019 4:46 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by bootOnWing »

ecrist wrote:Just added a semi-helpful note that patching the Tempate.html file "works for me".

For anyone having problems editing the file themselves, I've provided a patch here. Download the file Adium.patch.txt, and run the following commands:

Code: Select all

ecrist@meow:~-> cd /Applications/Adium.app
ecrist@meow:/Applications/Adium.app-> sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist@meow:/Applications/Adium.app-> 
Adjust the paths as necessary.
was able to do this and it worked. using adium for single chat (not sure about group). much appreciated!!!! =-)
danpritts
Harmless
Posts: 1
Joined: Thu Nov 07, 2019 6:40 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by danpritts »

Thanks so much everyone for taking the time to make & publish the fix!
OverSpun
Muffin
Posts: 29
Joined: Wed Oct 18, 2006 11:46 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by OverSpun »

bootOnWing wrote:
ecrist wrote:Just added a semi-helpful note that patching the Tempate.html file "works for me".

For anyone having problems editing the file themselves, I've provided a patch here. Download the file Adium.patch.txt, and run the following commands:

Code: Select all

ecrist@meow:~-> cd /Applications/Adium.app
ecrist@meow:/Applications/Adium.app-> sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist@meow:/Applications/Adium.app-> 
Adjust the paths as necessary.
was able to do this and it worked. using adium for single chat (not sure about group). much appreciated!!!! =-)
I also get the same issue with auto scrolling.

I could do that but I don't really understand all the meow stuff. Haha
User avatar
Robby
Cocoaforge Admin
Posts: 2610
Joined: Mon May 01, 2006 3:00 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by Robby »

A new Adium release which includes the fix is in the works.
ecrist
Harmless
Posts: 3
Joined: Thu Oct 31, 2019 11:01 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by ecrist »

OverSpun wrote:
bootOnWing wrote:
ecrist wrote:Just added a semi-helpful note that patching the Tempate.html file "works for me".

For anyone having problems editing the file themselves, I've provided a patch here. Download the file Adium.patch.txt, and run the following commands:

Code: Select all

ecrist@meow:~-> cd /Applications/Adium.app
ecrist@meow:/Applications/Adium.app-> sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist@meow:/Applications/Adium.app-> 
Adjust the paths as necessary.
was able to do this and it worked. using adium for single chat (not sure about group). much appreciated!!!! =-)
I also get the same issue with auto scrolling.

I could do that but I don't really understand all the meow stuff. Haha
Sorry, I should have left the shell prompt out:

Code: Select all

cd /Applications/Adium.app
sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist
Harmless
Posts: 3
Joined: Thu Oct 31, 2019 11:01 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by ecrist »

To expand on this for any administrators using JAMF, here's how I'm patching these in the field:

1) Create Extension Attribute called "Adium Patched", type string, input type script, with the following script:

Code: Select all

#!/bin/sh

grep "return 1;" /Applications/Adium.app/Contents/Resources/Template.html

if [ $? -eq 1 ];
then
	echo "<result>false</result>"
else
	echo "<result>true</result>"
fi
2) Create a Smart Computer Group called "Adium Not Patched" with the following criteria:
  • Application Title is Adium.app
    Adium Patched is false
    Operating System Version greater than or equal 10.15
3) Create a Computer Management Script called "Adium Scrolling Patch" with the following code:

Code: Select all

#!/bin/sh

tmpfile=$(mktemp)

cat <<PATCH > "$tmpfile"
diff -ur Contents.old/Resources/Template.html Contents/Resources/Template.html
--- Contents.old/Resources/Template.html	2017-04-27 04:31:20.000000000 -0500
+++ Contents/Resources/Template.html	2019-10-31 05:58:26.000000000 -0500
@@ -214,10 +214,12 @@
 
 		//Auto-scroll to bottom.  Use nearBottom to determine if a scrollToBottom is desired.
 		function nearBottom() {
-			return ( document.body.scrollTop >= ( document.body.offsetHeight - ( window.innerHeight * 1.2 ) ) );
+			//return ( document.body.scrollTop >= ( document.body.offsetHeight - ( window.innerHeight * 1.2 ) ) );
+			return 1;
 		}
 		function scrollToBottom() {
-			document.body.scrollTop = document.body.offsetHeight;
+			window.scrollTo(0, document.body.scrollHeight);
+			//document.body.scrollTop = document.body.offsetHeight;
 		}
 
 		//Dynamically exchange the active stylesheet
PATCH

cd /Applications/Adium.app
patch -p0 < "$tmpfile"

if [ $? -eq 0 ];
then
	echo "Adium patched successfully."
	rm "$tmpfile"
else
	echo "Adium patch failed - patch stored in $tmpfile"
fi
4) Create a computer policy to push the patch, set scope to your smart computer group "Adium Not Patched".

5) Profit?
/var/log/jamf.log wrote:Mon Nov 25 10:07:04 meow jamf[21771]: Checking for policies triggered by "recurring check-in" for user "ecrist"...
Mon Nov 25 10:07:06 meow jamf[21771]: Executing Policy Auto: Adium Scroll Patch
Mon Nov 25 10:07:07 meow jamf[21771]: Checking for patches...
Mon Nov 25 10:07:07 meow jamf[21771]: No patch policies were found.
OverSpun
Muffin
Posts: 29
Joined: Wed Oct 18, 2006 11:46 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by OverSpun »

ecrist wrote:
OverSpun wrote:
bootOnWing wrote:
was able to do this and it worked. using adium for single chat (not sure about group). much appreciated!!!! =-)
I also get the same issue with auto scrolling.

I could do that but I don't really understand all the meow stuff. Haha
Sorry, I should have left the shell prompt out:

Code: Select all

cd /Applications/Adium.app
sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
I finally got around doing this patch and it worked perfect. Thanks!
dudepron
Harmless
Posts: 2
Joined: Wed Jan 22, 2020 2:56 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by dudepron »

I did not use the script above, but the changes did work for me. Looking forward to an official release. Anything I can do to help.
User avatar
didymus
Harmless
Posts: 2
Joined: Sat Feb 08, 2020 11:14 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by didymus »

I'm very surprised this hasn't "officially" been fixed yet. This bug is annoying enough that I could see people not using Adium all together because of it. I decided to come check the forum and see if there were any suggestions, but if there wasn't any obvious fixes suggested I was going to get another client for XMPP.
User avatar
didymus
Harmless
Posts: 2
Joined: Sat Feb 08, 2020 11:14 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by didymus »

ecrist wrote:Just added a semi-helpful note that patching the Tempate.html file "works for me".

For anyone having problems editing the file themselves, I've provided a patch here. Download the file Adium.patch.txt, and run the following commands:

Code: Select all

ecrist@meow:~-> cd /Applications/Adium.app
ecrist@meow:/Applications/Adium.app-> sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist@meow:/Applications/Adium.app-> 
Adjust the paths as necessary.
Thank you!! This worked! Had to figure out what was meant by `->` though, lol.
doomsday
Harmless
Posts: 10
Joined: Mon Oct 14, 2019 11:59 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by doomsday »

hi guys. im still have same issue.
can someone please help noob how to fix it? really won't change a xmpp client, but this auto-scrolling bug just killing me :(
doomsday
Harmless
Posts: 10
Joined: Mon Oct 14, 2019 11:59 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by doomsday »

ecrist wrote:Just added a semi-helpful note that patching the Tempate.html file "works for me".

For anyone having problems editing the file themselves, I've provided a patch here. Download the file Adium.patch.txt, and run the following commands:

Code: Select all

ecrist@meow:~-> cd /Applications/Adium.app
ecrist@meow:/Applications/Adium.app-> sudo patch -p0 < ~/Downloads/Adium.patch.txt
patching file Contents/Resources/Template.html
ecrist@meow:/Applications/Adium.app-> 
Adjust the paths as necessary.
thanks a lot, just made it myself lol.
codenamerebel
Harmless
Posts: 4
Joined: Tue Jul 14, 2020 6:04 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by codenamerebel »

So did the effort for the new release just die off since we got a "patch" we can implement?
User avatar
Robby
Cocoaforge Admin
Posts: 2610
Joined: Mon May 01, 2006 3:00 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by Robby »

Correct.
codenamerebel
Harmless
Posts: 4
Joined: Tue Jul 14, 2020 6:04 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by codenamerebel »

Any chance that there will be an effort to finish an update? Especially with the upcoming changes to macOS?
User avatar
Simba Cub
Mocha
Posts: 504
Joined: Thu Apr 28, 2005 8:22 pm
Location: Sussex, UK
Contact:

Re: Auto-scrolling not working after upgrade to Catalina

Post by Simba Cub »

codenamerebel wrote:Any chance that there will be an effort to finish an update? Especially with the upcoming changes to macOS?
I wouldn't hold my breath for an update. There's little reason for one now. Most of the big networks have skittled off as have most of the users. It's a real pity. I used to love the social interaction of times past, staying in communication with everyone so easily...
codenamerebel
Harmless
Posts: 4
Joined: Tue Jul 14, 2020 6:04 pm

Re: Auto-scrolling not working after upgrade to Catalina

Post by codenamerebel »

Simba Cub wrote:
codenamerebel wrote:Any chance that there will be an effort to finish an update? Especially with the upcoming changes to macOS?
I wouldn't hold my breath for an update. There's little reason for one now. Most of the big networks have skittled off as have most of the users. It's a real pity. I used to love the social interaction of times past, staying in communication with everyone so easily...
I still use it as my XMPP client and it works REALLY well for that. I guess I just hate to see It die off. :(
domib
Harmless
Posts: 1
Joined: Mon Aug 10, 2020 9:23 am

Re: Auto-scrolling not working after upgrade to Catalina

Post by domib »

Trolan wrote:The PR for the scroll fix also has a compatible change for Renkoo, as that was the only default style with an overload for scrollToBottom();
Is there any way to fix the Renkoo style manually or are the changes of the PR too significant?
Post Reply