Test Build for Rate Limiting Error

magicite · Post by **magicite** » Fri Oct 21, 2005 3:04 pm

Address book names are just fine. Interestingly enough, one person on my list does have a last name, and I entered him in (in Adium) shortly before upgrading to this beta version (and for whatever reason, it gave me lots of trouble; would show him offline after I added him (he was online), would not be in my buddy list after I relogged in). Could this be related?

Post by **evands** » Fri Oct 21, 2005 3:42 pm

Someone's going to need to post screen shots or something... what do you mean "re entering the last names"? Are you saying that Adium deleted one word of an alias you had entered with Adium but not another? And that word happened to be the last word of the alias? Or is it a last name pulled from the address book?

Tipo 61 · Post by **Tipo 61** » Fri Oct 21, 2005 3:59 pm

I have adium set up to use Alias's as the display names via: View -> Contact Name Format -> Alias.

What I mean by re entering the last names I mean highlighting a contact, getting info, and retyping the alias in the contact settings tab.

When I upgraded to this test build, it looks like Adium remembered the First word of the Alias, usually the first name, but forgot the second word, and didn't display it. I wish I could post some screens to help, but re entering peoples names in Adium (not addressbook, the aliases are fine there) has fixed the problem

hornet517 · Post by **hornet517** » Fri Oct 21, 2005 4:31 pm

sphen wrote:how about this mirror....

http://escamuel.org/Adium-85.1.prelim.debug.app.zip

Yes this one works quite well, except i still had to re-enter the last names.

Post by **evands** » Fri Oct 21, 2005 5:11 pm

Tipo 61 wrote:I have adium set up to use Alias's as the display names via: View -> Contact Name Format -> Alias.

What I mean by re entering the last names I mean highlighting a contact, getting info, and retyping the alias in the contact settings tab.

When I upgraded to this test build, it looks like Adium remembered the First word of the Alias, usually the first name, but forgot the second word, and didn't display it. I wish I could post some screens to help, but re entering peoples names in Adium (not addressbook, the aliases are fine there) has fixed the problem

And these two word aliases which lost just the last word were specified initially via the Alias area in the Get Info window, not from the address book?

Post by **evands** » Fri Oct 21, 2005 5:11 pm

hornet517 wrote:
sphen wrote:how about this mirror....

http://escamuel.org/Adium-85.1.prelim.debug.app.zip

Yes this one works quite well, except i still had to re-enter the last names.

You had to re-enter them a second time?

Tipo 61 · Post by **Tipo 61** » Fri Oct 21, 2005 5:22 pm

evands wrote:
Tipo 61 wrote:I have adium set up to use Alias's as the display names via: View -> Contact Name Format -> Alias.

What I mean by re entering the last names I mean highlighting a contact, getting info, and retyping the alias in the contact settings tab.

When I upgraded to this test build, it looks like Adium remembered the First word of the Alias, usually the first name, but forgot the second word, and didn't display it. I wish I could post some screens to help, but re entering peoples names in Adium (not addressbook, the aliases are fine there) has fixed the problem
And these two word aliases which lost just the last word were specified initially via the Alias area in the Get Info window, not from the address book?

Hmm, that's hard to tell, some of my older contacts from back in the iChat days were imported from the address book, but most of the newer ones were set in Adium. One word Aliases were fine, two word ones lost the second word

magicite · Post by **magicite** » Fri Oct 21, 2005 6:06 pm

In my case, I switched to adium fulltime from iChat when v0.85 came out. So, I'm assuming it got all of the last names from address book or iChat. Now, as soon as I updated to this test build, only the first name of every contact shows up. For instance, if a name displayed as "John Doe" before, it would now just display as "John."

Edit -- Fixed (very important) typo. 'now' used to be 'not.' This significantly changes the meaning of what I was trying to say.

Post by **The_Tick** » Sat Oct 22, 2005 3:38 am

Alright, the beta is up over at http://beta.adiumx.com

Post by **evands** » Sat Oct 22, 2005 3:50 am

Tipo 61 wrote:Hmm, that's hard to tell, some of my older contacts from back in the iChat days were imported from the address book, but most of the newer ones were set in Adium. One word Aliases were fine, two word ones lost the second word

Gonna be honest here: I totally don't believe that any affected contacts were coming from anywhere besides the address book. When I can code again I'm going to review a patch to the address book import code which was merged to .8x. There is no code anywhere in Adium which could remove just one word of the alias even accidentally unless we're talking about the address book, where first, middle, and last names are imported independently and then combined into a single phrase.

uttaddmb · Post by **uttaddmb** » Sat Oct 22, 2005 2:53 pm

Tipo 61 and magicite, I think you might be misinterpreting the problem. I downloaded the test build and it looked like it had erased everyone's last name, but it had really just changed the setting for how to display aliases. I went into Preferences > Advanced > Address Book and changed it back to First Last, and everything was peachy. Did you try that?

Post by **evands** » Sat Oct 22, 2005 3:16 pm

Exactly, uttaddmb.

In any case, fixed for b2 / the release (http://trac.adiumx.com/changeset/13778).

mrboarderman · Post by **mrboarderman** » Sat Oct 22, 2005 7:26 pm

What was exactly changed?

Would I be able to put any of the source so that I can continue to use metal adium but without the rate limiting error?

JediL1 · Post by **JediL1** » Mon Oct 24, 2005 1:17 am

It Works!

Though, it is delayed (for obvious reasons) perhaps a bit too long. Are the restrictions in Adium for fetching away messages from AIM the lowest interval they can be without setting off the rate limiting error?

If not, I would like to see them a bit shorter as it can be a few minutes before away messages update.

Post by **The_Tick** » Mon Oct 24, 2005 1:21 am

JediL1 wrote:It Works!

Though, it is delayed (for obvious reasons) perhaps a bit too long. Are the restrictions in Adium for fetching away messages from AIM the lowest interval they can be without setting off the rate limiting error?

If not, I would like to see them a bit shorter as it can be a few minutes before away messages update.

We set them as high as we could.

Post by **evands** » Mon Oct 24, 2005 1:35 am

Pending a Proper implementation that is smart about how the rate limiting system works and dynamically modulates our packets to avoid setting it off(which we should have with joscar), it's better to delay the away messages than to risk hitting border cases for users with large buddy lists.