Regrression: Previous Tab does not go to last Tab starting v3.8.0 (fixed in v3.8.5)

An RSS/Atom newsreader with features comparable to commercial newsreaders.
Post Reply
skybow
Harmless
Posts: 2
Joined: Thu Jan 19, 2023 2:27 pm

Regrression: Previous Tab does not go to last Tab starting v3.8.0 (fixed in v3.8.5)

Post by skybow »

Hello,

after updating to the latest Vienna RSS version I noticed that the round robin feature when navigating to "previous tab/next tab" won't work anymore.
I tried to find the place in code where things go wrong, however it comes down to some replacement that was done when moving from v3.7.x to v3.8.x: The original that performed the round robin feature was in "Browser.m" in function/method "showPreviousTab/showNextTab", but this code is not called anymore in v3.8.0.

Sorry if this forum might be the wrong place to post this, but I haven't gotten involed into Vienna RSS but want to provide this feedback somewhere. I appreciate the work on Vienna RSS very much and I would like to update to the latest v3.8.x release again, but for me personally this regression is a major drawback. I am willing to submit this into the issue queue in GitHub, but I wanted to check in the forum first to see, if there are others that are missing this feature

TIA
skybow
Last edited by skybow on Sat Jan 21, 2023 3:04 pm, edited 1 time in total.
barijaona
Vienna Team
Posts: 657
Joined: Sat Nov 12, 2011 11:10 am
Contact:

Re: Regrression: Previous Tab does not go to last Tab starting v3.8.0

Post by barijaona »

Hi,

Thanks for noticing this.

Can you confirm my understanding of the issue?
1/ the problem appears when you attempt to go from the first tab (the "Articles" tab) to the last one by using the "Window->Previous Tab" menu item (or its keyboard equivalent Command-Option-⬅︎)
2/ similar issue when you attempt to switch from the last tab to the first one using the keyboard shortcut Command-Option-➡︎
3/ the bug only appears when "Preview New Browser" is activated (in the Advanced section of the settings / preferences). When you use the old browser, things are working as expected.
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
skybow
Harmless
Posts: 2
Joined: Thu Jan 19, 2023 2:27 pm

Re: Regrression: Previous Tab does not go to last Tab starting v3.8.0 (fixed in v3.8.5)

Post by skybow »

Hi barijaona,

yes you did understand everything right.
I also retried all with version 3.8.4 (for I downgraded to 3.7.5) using the "New Browser" both on an off:
When on, it failes, when off it works with this version.

I also saw that you released version 3.8.5 with this issue fixed and I can confirm that it works with this version as expected with both "New Browser" on and off. Thanks a lot for the quick response on this fix and for all the work on Vienna RSS.

skybow
barijaona
Vienna Team
Posts: 657
Joined: Sat Nov 12, 2011 11:10 am
Contact:

Re: Regrression: Previous Tab does not go to last Tab starting v3.8.0 (fixed in v3.8.5)

Post by barijaona »

You're welcome !
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report
Post Reply