Page 1 of 1

GrowlTunes 1.1.2 bug

Posted: Sun Jun 01, 2008 1:45 am
by dude2k
There's a bug in GrowlTunes 1.1.2. In GrowlTunesController.m the lines

Code: Select all

	if ([[[NSBundle bundleWithPath:itunesPath] objectForInfoDictionaryKey:@"CFBundleShortVersionString"] floatValue] < 4.7f)
		[self setPolling:YES];
	else
		[self setPolling:NO];
do not work if iTunes version number consists of 3 numbers, which accounts for example for iTunes 7.6.2: "7.6.2" is not convertable to a floating number.
The result is that GrowlTunes erroneously switches to Retro Polling mode => no rating display, no artwork display, bad performance...

I am no Objective C programmer, but a quick fix worked for me. I commented the first 3 lines of aforementioned code lines out.
A better strategy would be: if the first character (being always a number) is below 5. If so convert to a float and do the check above. If true enable polling. In all other cases disable polling.

Anyway, thanks for a nice tool!

Re: GrowlTunes 1.1.2 bug

Posted: Mon Jun 02, 2008 6:14 pm
by The_Tick
Can you ping the discuss list on this?

Re: GrowlTunes 1.1.2 bug

Posted: Tue Jun 03, 2008 4:33 pm
by dude2k
Done, posted my report to Growl's discuss list on Google.