Not loading images in one RSS feed

An RSS/Atom newsreader with features comparable to commercial newsreaders.
Stubb
Harmless
Posts: 4
Joined: Sat Jul 16, 2016 3:19 pm

Not loading images in one RSS feed

Postby Stubb » Sat Jul 16, 2016 3:26 pm

I'm running Vienna Version 3.1.5 :e14f77e: on OS X 10.11.5.

Almost all of images in "Winter is Coming" (http://winteriscoming.net/feed/) posts show up as broken in Vienna. Is this a problem with how the site lists images or how Vienna handles them? If the latter, is it fixable?

sandstrom
Latté
Posts: 54
Joined: Tue Jul 09, 2013 8:33 am

Re: Not loading images in one RSS feed

Postby sandstrom » Sun Jul 17, 2016 12:56 am

Looks like an eventual Vienna weakness (bug?)

Code: Select all

 <img class="aligncenter wp-image-77092 size-large" src="http://winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale-630x352.jpg" alt="Iain Glen" width="630" height="352" srcset="//winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale-630x352.jpg 630w, //winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale-300x168.jpg 300w, //winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale-810x452.jpg 810w, //winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale-1140x637.jpg 1140w, //winteriscoming.net/wp-content/uploads/2015/05/jorah-greyscale.jpg 1200w" sizes="(max-width: 630px) 100vw, 630px" />


Vienna looks for the image(s) in the srcset attribute (fully supported by Webkit on 10.9+). Those are referenced thus: `//winteriscoming.net/` - and Vienna translate that into a `file://` URL (an image available locally), which of course it cannot find. It should ultimately prepend a `http://` protocol in this case.

(technically Vienna is not wrong - per spec it should use the local context when prepending the protocol).

Stubb
Harmless
Posts: 4
Joined: Sat Jul 16, 2016 3:19 pm

Re: Not loading images in one RSS feed

Postby Stubb » Tue Jul 19, 2016 12:21 am

sandstrom wrote:Vienna looks for the image(s) in the srcset attribute (fully supported by Webkit on 10.9+). Those are referenced thus: `//winteriscoming.net/` - and Vienna translate that into a `file://` URL (an image available locally), which of course it cannot find. It should ultimately prepend a `http://` protocol in this case.

(technically Vienna is not wrong - per spec it should use the local context when prepending the protocol).


Actually, VIenna is wrong as per section 5.2 of RFC 3986. If a URL does not specify a scheme (e.g., src="//winteriscoming.net…"), then the target URI should prepend the scheme of the base content. That is, prepend "https:" if the base content was loaded over https, prepend "file:" if the base content was loaded from a file, etc.

User avatar
josh64x2
Cocoaforge Admin
Posts: 159
Joined: Sat Sep 06, 2014 1:38 am
Location: Sydney, Australia
Contact:

Re: Not loading images in one RSS feed

Postby josh64x2 » Wed Jul 20, 2016 11:26 am

OK I will take a look at this on the weekend. Can you please raise it as an issue over at GitHub https://github.com/ViennaRSS/vienna-rss/issues/new ?
Unfortunately I am very busy at the moment so I can't do it.

Thanks!
I help with Vienna development.

Stubb
Harmless
Posts: 4
Joined: Sat Jul 16, 2016 3:19 pm

Re: Not loading images in one RSS feed

Postby Stubb » Wed Jul 20, 2016 1:12 pm

Done—submitted as issue #700.

barijaona
Vienna Team
Posts: 627
Joined: Sat Nov 12, 2011 11:10 am
Contact:

Re: Not loading images in one RSS feed

Postby barijaona » Wed Jul 20, 2016 2:17 pm

I have to confess a few things :
1/ I thought this issue was very simple to fix but I endured a two days struggle because of Webkit's same origin policy. You must specify a 'file:' base URL if you want an easy access to local resources. In our case, we need to access CSS, images and scripts for styling the RSS.
2/ I am supposed to be on vacation, and my wife and kids are wondering why I am so busy…
3/ I have not seen a single episode of Games Of Thrones in my whole life, and I don't remember the last time I watched a TV series…

My conclusion after finding the solution last night ? For me, playing Game Of Code is probably more satisfying than watching Game Of Thrones, but if you want improvement in Vienna, don't try to prove me wrong ! :smt077 :shockcombo:
I contribute to Vienna RSS as a developer.
Please, don't forget those tips for writing a good bug report

Stubb
Harmless
Posts: 4
Joined: Sat Jul 16, 2016 3:19 pm

Re: Not loading images in one RSS feed

Postby Stubb » Wed Jul 20, 2016 7:50 pm

barijaona wrote:My conclusion after finding the solution last night ? For me, playing Game Of Code is probably more satisfying than watching Game Of Thrones, but if you want improvement in Vienna, don't try to prove me wrong ! :smt077 :shockcombo:


Passive entertainment isn't going to beat the satisfaction of noodling out a tough problem, but Game of Thrones is among the strongest contenders =-)

Thanks for addressing the problem—I look forward to trying the next build!


Return to “Vienna”

Who is online

Users browsing this forum: Google Feedfetcher